-
Notifications
You must be signed in to change notification settings - Fork 1.3k
clear out interrupt when freeing the timer #5613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In testing, this patch seems to fix the initial issue in #5418. However, the second hang mentioned in that issue; where a similar hang can be generated when running the script from https://learn.adafruit.com/rgb-led-matrices-matrix-panels-with-circuitpython/connecting-with-feather-rp2040-featherwing by hitting CTRL-C during startup; still exists. I captured a stack from that hang:
It looks like we're still getting into the PWM interrupt handler when not configured to handle things there. |
Adding the same two new lines from common_hal_rgbmatrix_timer_free() at the end of common_hal_rgbmatrix_timer_disable() seems to resolve both the "syntax error" issue as well as the "CTRL-C" scenerio. |
Is this is still in process, or does it await a review? |
I need to incorporate @DavePutz 's suggestion |
As it'll be at least a week before I look at this again I encourage @DavePutz to PR his tested and working fix for this issue. |
@DavePutz ready for your re-review. Note that I've retargeted this PR for 7.1.x, rather than main. |
Do you consider this a priority for 7.1.0? |
not super urgent for me, it's just that this was made way before we split 7.1.x from main. I can switch it back, or we can merge it after 7.1.0 goes out. |
Sounds good. Let's merge it after 7.1.0 is final, and then we can merge this and any remaining changes into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. In my testing this fixed both issues raised in issue #5418.
@DavePutz I did not put together hardware to test your suggested fix. If you're able to test this, please do so and let me know how it goes.
I hope this Closes #5418