pin specific versions of cascadetoml & tomlkit, temporarily #5750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
approved these changes
Dec 20, 2021
|
Do you need me to do a release? |
|
@tannewt yeah, getting the tagged 0.3.2 onto pypi would mean this wasn't necessary. |
|
the cascadetoml release didn't happen yesterday so let's just go ahead and take this for now... |
|
Sorry I didn't do this yesterday. I did too good of a job of ignoring email. I've released 0.3.3. (Using |
hathach
pushed a commit
to hathach/circuitpython
that referenced
this pull request
Dec 23, 2021
Fixes issue adafruit#5750. Signed-off-by: Damien George <damien@micropython.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tomlkit==0.8.0 introduced an incompatiblity with cascadetoml=0.3.1. cascadetoml has been fixed, but right now there's a speed bump preventing us from performing a pypi release of 0.3.2. Instead, pin both tomlkit and cascadetoml at a version that works as needed. Once cascadetoml is release to pypi, this should be reverted.