Bring 7.1.x changes into main - cascadetoml undo + alarm fixes #5761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix cascadetoml more
Revert "pin specific versions of cascadetoml & tomlkit, temporarily"
tannewt
previously requested changes
Dec 22, 2021
The windows change was never merged into |
|
I agree, this needs to revert f527ef0. |
That commit is only in 7.1.x? Could you submit a 7.1.x revert PR? Thanks. |
|
I made #5765 through the github UI. |
Fix recording of wake_alarm
Revert "Fix cascadetoml more"
|
This PR is now a general |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5754 now that there is a fixed release of
cascadetoml.