Skip to content

pIRKey tested w/ hardware #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2018
Merged

pIRKey tested w/ hardware #580

merged 1 commit into from
Feb 5, 2018

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Feb 5, 2018

basically a trinket or gemma with only dotstar LED + IR Receiver

@dhalbert
Copy link
Collaborator

dhalbert commented Feb 5, 2018

@ladyada I looked at the new files and compared with Trinket and they look OK by me. Do you want a review and merge?
@tannewt ok by you?

@ladyada
Copy link
Member Author

ladyada commented Feb 5, 2018 •
edited
Loading

hiya yes plz review and merge if acceptable for 2.2.2
thanks!

@dhalbert dhalbert self-requested a review February 5, 2018 04:49
@ladyada ladyada requested a review from tannewt February 5, 2018 04:49
dhalbert
dhalbert approved these changes Feb 5, 2018
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Eyeballed differences with Trinket, etc.

@dhalbert dhalbert merged commit b6114d1 into adafruit:2.x Feb 5, 2018
@ladyada
Copy link
Member Author

ladyada commented Feb 5, 2018

PCBs ordered!

@ladyada ladyada deleted the pirkey branch February 5, 2018 05:05
@dhalbert
Copy link
Collaborator

dhalbert commented Feb 5, 2018

woowee!

@ladyada ladyada restored the pirkey branch June 22, 2018 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladyada @dhalbert