-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Move frozen adafruit_circuitplayground to CPX subdirectory #6346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see this happen, it gives us some breathing room. I suspect the PR will be red in its current state, for the reasons given in the PR, though, so no surprises there but it means we can't merge yet.
I am going to defer this past 7.3.0, since it didn't build, and I want to see how it affects builds on Windows, which some people do. |
Yup, it's waiting on the CPX PR, which needs a merge and release. |
I tested this successfully with a custom build using the branch from adafruit/Adafruit_CircuitPython_CircuitPlayground#117 on a CPX. I ran many of the examples from this guide: https://learn.adafruit.com/circuitpython-made-easy-on-circuit-playground-express/circuit-playground-express-library and found them working as expected. On the CPX builds using current repo the remaining free space for an English language build was:
With the modification to use the branch from this PR the space is:
So this does seem like a decent chunk of space savings. Thanks for figuring this out @Neradoc! this will allow more helpful features to fit in these builds. |
I believe the difference in space that you find might be in part due to the fact that the Circuitpython PR has not been rebased on latest. And neither has the library PR. Here is what I get when I make sure to pick the right ones:
That's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a clever and straightforward solution. Let's do it. After thinking about the Windows development issues, I believe it will be OK. Thanks!
move frozen adafruit_circuitplayground to express subdirectory - 7.3.x backport of #6346
This PR requires an update and release of the adafruit_circuitplayground library (followed by updating frozen modules in this PR) before it can be merged.
It changes the frozen directory of the circuitplayground library to a subdirectory with a copy of the library made using symbolic links excluding the CPB specific file. Reduces the size of the CPX build by 1148 bytes.
Note: it's important now to NOT freeze in the parent directory or it will include double files. If we ever want to freeze in the library on the CPB, a
frozen_cpb
sub directory will have to be made.