Turn on title bar everywhere and enhance it #6698
Conversation
* Tweak scroll area position so last line is complete and top is under the title bar. * Pick Blinka size based on the font to minimize unused space in title bar. Related to micropython#2791 * Update the title bar after terminal is started. Fixes micropython#6078 Fixes micropython#6668
This replaces supervisor.enable_autoreload() and supervisor.disable_autoreload(). It also allows user code to get the current autoreload state. Replaces micropython#5352 and part of micropython#5414
There was a problem hiding this comment.
Great! The code looks good. I noted the following things:
- The
@n ExceptionNamein the status bar does not include the filename. So for instance:
code.py:
import busio
import xx.py:
1/0says @1 DivisionByZeroError without saying which file it's in. If you feel there is room, I think including the filename would be good, since the error may be quite deep. The filename and the line number are more important than a possibly truncated exception name.
- I connected, then changed the wifi password to be wrong, did a hard reset. I see "Authentication Failure" after a 15-second or so delay. Then I changed the password back to be correct, and did another hard reset. On the device display (Feather ESP32S2 TFT), the IP address is shown, but the terminal title bar (running
tio) said "No IP", and it did not show thecode.py output:. This is a little bizarre because it should have come up properly and printed the usual initial text. Instead tio just said "Connected" and idid not print anything. This seems like some kind of timing problem.
It's OK to merge as is, and consider these later. I can open issues about them.
Ya, I agree that'd be better. I'm not exactly sure how to get that info atm. The line number was convenient and I was hoping it was the top level, not bottom. (But I obviously didn't test it.) I can test on the Feather S2 TFT when I get to this. I didn't try it specifically. Up to you if you want to merge now or not. Either way these changes will cause full CI runs. |
|
I will open some issues and merge now. |
|
Oops, there is a merge conflict anyway. Could you check on that, and then I'll approve and merge? |
The title bar now has code execution status on all builds and BLE workflow info on those.
This PR also has a number of tweaks and fixes (hopefully not too distracting):
UID:line to boot_out.txt so to identify a device from a mounted filesystem.Wi-Fi:prefix when showing an IP to increase the likelihood it is all displayed.