Skip to content

Add exception filename to title bar #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Aug 8, 2022

Add the exception filename after the line number and change the
line number so it is in that file. It used to always be code.py.

Fixes #6702

Add the exception filename after the line number and change the
line number so it is in that file. It used to always be code.py.

Fixes micropython#6702
@tannewt tannewt added this to the 8.0.0 milestone Aug 8, 2022
@tannewt tannewt requested a review from dhalbert August 8, 2022 20:56
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

How about filename.py@1 instead of @1 filename.py? That takes one less character. (EDIT: or 1@filename.py, maybe that's even better).

Also I was thinking about using an ! instead of @ to make it clearer it was something unusual.

@tannewt
Copy link
Member Author

tannewt commented Aug 9, 2022

Ok, I've changed it to line@filename.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this will be even more informative!

@tannewt tannewt merged commit 59b4353 into adafruit:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title bar exception indicator: include filename
2 participants