Skip to content

Remove all kwarg from ScanEntry.matches #6730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2022
Merged

Remove all kwarg from ScanEntry.matches #6730

merged 1 commit into from
Aug 10, 2022

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Aug 9, 2022

Fixes #3007

@tannewt tannewt added this to the 8.0.0 milestone Aug 9, 2022
@tannewt tannewt requested a review from dhalbert August 9, 2022 21:39
dhalbert
dhalbert approved these changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally we get to do this :) Thanks!

@tannewt
Copy link
Member Author

tannewt commented Aug 10, 2022

Last job looks successful but hung on cleanup. Merging now.

@tannewt tannewt merged commit e50fc23 into adafruit:main Aug 10, 2022
@dhalbert dhalbert mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
breaks api
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

_bleio.ScanEntry.matches(..., all=) keyword arg conflicts with all()
2 participants
@tannewt @dhalbert