Remove support for auto-brightness #6734
Conversation
|
circuitpython-stage updated by #6740 to complete this transition for frozen modules |
|
Just so I understand, I was using "board.DISPLAY.brightness" to adjust the brightness on my ESP32-S3 TFT and after the autobrightness removal, I can't adjust it at all now. Was this intended? I understand the autobrightness doesn't work, but I was not expecting the "manual" brightness setting to be removed entirely as well. |
That was not the intention. I tested it with a PyPortal, but not an ESP32-S3 TFT. Could you open an issue with a small test program? Thanks. |
Fixes #5476 by removing
auto_brightnessand related support completely.@deshipu @tannewt My understanding of the comments in #5476, particularly the later ones, is that auto-brightness never worked, and we may as well just remove it, which is what I proposed in that issue. If this is not correct, then I'll close or change this.
This PR explicitly removes the
.auto_brightnessattribute onDisplayandFrameBufferDisplay. It does not just render it inoperable in 8.0.0, to be removed in 9.0.0. I could do such a staged removal if you think it advisable.I found about five boilerplate references to
.auto_brightnessin the Learn Guide repo, and about three in the libraries, all of which could easily be handled.@deshipu There are also a couple of mentions of
.auto_brightnessincircuitpython-stage. Before this PR is merged, those would need to be removed and I would update the frozen submodule.