asyncio: we should dogfood our own asyncio implementation during automated tests #7059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also depends on adafruit/Adafruit_CircuitPython_Ticks#8 otherwise adafruit_ticks is unimportable and the tests are just skipped. Several of the tests fail, and one runs forever instead of terminating. We should fix our asyncio until the tests patch, then incorporate this change.
with e.g., 'make TEST_EXTRA="extmod/uasyncio*.py" test'
|
Together with these PRs, the tests now pass while using our asyncio module implementation (Adafruit_CircuitPython_asyncio):
|
|
Or maybe it'll succeed and leave me wondering what the heck is up :) |
|
ah the asyncio tests will be skipped until "try time.ticks_ms" is merged. |
.. since Adafruit_CircuitPython_asyncio is hard-coded to this _TICKS_PERIOD not the one that would otherwise be used on Unix This fixes all the uasyncio test failures on Unix
A task that has been sent to the loop's exception handler due to being re-scheduled twice will then subsequently cause a `raise None` if it is subsequently awaited. In the C version of task.py, this causes a segfault. This makes the await succeed (via raising StopIteration instead). Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
|
The frozen modules have all the necessary updates now, so this PR is ready for review @dhalbert |
dhalbert
approved these changes
Oct 19, 2022
|
Six jobs failed for network reasons, and one got stuck for network reasons: I have seen this particular stuckness several times, at the same percentage finished. Cancelling the run to stop this from spinning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't work yet. It needs adafruit/Adafruit_CircuitPython_Ticks#8 in order to even fail (rather than skipping the tests). After that, some tests fail and one loops/hangs indefinitely.
Then, we need adafruit/Adafruit_CircuitPython_asyncio#30 to fix the bugs.
Closes #6706