2.x: handle bad power on reset better #802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
approved these changes
May 3, 2018
There was a problem hiding this comment.
I was able to consistently wipe the file system when attempting to do it on purpose the last time we had this issue. I again attempted to wipe the file system and was entirely unsuccessful. I tested with both a lipo battery and the AAA battery pack. Great job getting this fixed!
tannewt
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #280.
boot_out.txtif there's noboot.pyor equivalent, and the version info inboot_out.txtwill not change.boot.py, wait 1.5 seconds before running it and writing its output toboot_out.txt.storage.erase_filesystem()for ease of erasing filesystem (already in 3.0).This makes bouncy switched and plugged power connections much less likely to erase the filesystem.
The
main.hfile is a bit silly, but it's not worth refactoringinit_flash_fs()out ofmain.cnow, since 2.x is in maintenance mode.I will port this to 3.0.