Skip to content

3.0: Handle bad power on reset. #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2018
Merged

3.0: Handle bad power on reset. #804

merged 2 commits into from
May 4, 2018

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented May 4, 2018 •
edited
Loading

This is the 3.0 version of #802. Fixes #280 for 3.0. Fixes #651.

  1. Do not write boot_out.txt if there's no boot.py or equivalent, and the version info in boot_out.txt will not change.
  2. If there is a boot.py, wait 1.5 seconds before running it and writing its output to boot_out.txt.
  3. Change BOD33 brownout threshold to ~2.7V for SAMD21 and SAMD51.

This makes bouncy switched and plugged power connections much less likely to erase the filesystem.

@dhalbert dhalbert requested a review from tannewt May 4, 2018 03:47
tannewt
tannewt approved these changes May 4, 2018
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you!

@tannewt tannewt merged commit d32349c into adafruit:master May 4, 2018
@dhalbert dhalbert deleted the boot_out_fixes branch May 4, 2018 20:09
@jerryneedell jerryneedell mentioned this pull request May 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @tannewt