Skip to content

2.x: Fix regression preventing remount as readwrite in boot.py #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2018
Merged

2.x: Fix regression preventing remount as readwrite in boot.py #812

merged 1 commit into from
May 7, 2018

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented May 7, 2018

2.3.0 moved a call setting root filesystem to readonly to after boot.py execution, which meant that boot.py couldn't change the filesystem permission using storage.remount(). Fix this regression :(

@dhalbert dhalbert requested a review from tannewt May 7, 2018 04:16
@dhalbert
Copy link
Collaborator Author

dhalbert commented May 7, 2018

I'll need to make a 2.3.1 release.

tannewt
tannewt approved these changes May 7, 2018
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix here as well!

@tannewt tannewt merged commit 6e95c90 into adafruit:2.x May 7, 2018
@tannewt tannewt mentioned this pull request May 7, 2018
Closed
@dhalbert dhalbert deleted the 2.x-filesystem-writability-on-boot branch June 15, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @tannewt