Skip to content

remove last uses of 'u' prefix #8318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

dhalbert
Copy link
Collaborator

There were some accidental reversions to u-prefixes due to MP_REGISTER_MODULE() changes. But some tests still depended on u prefixes. I took the leap of removing all the u prefixes, getting most of the way toward micropython#9069, which does the same thing in MicroPython.

@dhalbert dhalbert requested a review from jepler August 22, 2023 15:24
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! By number of files this was a lot of work. I spotted one mistaken change, though

jepler
jepler previously approved these changes Aug 22, 2023
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert
Copy link
Collaborator Author

@jepler OK, everything passing now except for the docs build, which you fixed and is in the 8.2.x->main merge.

Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing doc build should not block merging this PR.

@jepler jepler merged commit dfb070b into adafruit:main Aug 22, 2023
@dhalbert dhalbert deleted the remove-u-prefix branch February 16, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

leading 'u' required on for json module
2 participants