Skip to content

Add friendlier error when .show() used #8517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add friendlier error when .show() used #8517

merged 1 commit into from
Oct 25, 2023

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Oct 24, 2023

Fixes #8499

Adafruit CircuitPython 9.0.0-alpha.1-99-gecaf9e6b14-dirty on 2023-10-24; Adafruit Feather ESP32-S3 TFT with ESP32S3
>>> import board
>>> board.DISPLAY.show(None)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: .show(x) removed. Use .root_group = x
>>>

@tannewt tannewt requested a review from dhalbert October 24, 2023 22:42
@dhalbert
Copy link
Collaborator

now there are merge conflicts due to #8493, as expected

dhalbert
dhalbert approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit c3cc76d into adafruit:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

9.x AttributeError: 'Display' object has no attribute 'show'
2 participants
@tannewt @dhalbert