Revert "Revert to micropython's version of mp_hal_stdout_tx_strn_cooked" #8614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
Nov 15, 2023
They had diverged. This doesn't appear to be the cause of the build failure on adafruit#8614, but it doesn't hurt to make sure they always match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting #8614: breaks serial.
Tested before and after reverting on a Feather ESP32-S3 Reverse TFT. Before reverting, serial does not come up consistently. Sometimes will appear after a hard reset, but then stop working.