Skip to content

Conversation

furbrain
Copy link

This fixes a bug in the previous nrfx implementation that failed to fully shut down the UART. This lead to a
sleep current consumption of ~1mA.

My initial attempt to fix this #8089 somehow broke the USB as described in #8391, so it was reverted.

This takes code from a later version of the nrfx firmware.

@tannewt tannewt requested a review from dhalbert January 22, 2024 23:53
dhalbert
dhalbert previously approved these changes Jan 22, 2024
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@dhalbert dhalbert self-requested a review January 22, 2024 23:56
@dhalbert dhalbert dismissed their stale review January 22, 2024 23:57

I meant to say I will test this first.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with test from #8391. Works -- Does not exhibit the problem described there.

Thanks!

@dhalbert dhalbert merged commit a28f853 into adafruit:main Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants