Improve neopixel on ESP #8920
Merged
Improve neopixel on ESP #8920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greedily grab as much RMT memory as we can. It blocks other RMT transmit channels but we only use it temporarily anyway. The more we can grab, the fewer interrupts are needed to keep the transmit going. Flickers may still happen due to file system writes but most of the time the animation just pauses. On ESP32, move CircuitPython to the second core. This helps NeoPixel by moving the RMT interrupt to the second core as well. When testing ESP32 I noticed that settings.toml writes won't apply until after hard reset. This removes that constraint but still requires the password to enable the web workflow. Fixes micropython#3835
jepler
approved these changes
Feb 15, 2024
dhalbert
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greedily grab as much RMT memory as we can. It blocks other RMT transmit channels but we only use it temporarily anyway. The more we can grab, the fewer interrupts are needed to keep the transmit going.
Flickers may still happen due to file system writes but most of the time the animation just pauses.
On ESP32, move CircuitPython to the second core. This helps NeoPixel by moving the RMT interrupt to the second core as well.
When testing ESP32 I noticed that settings.toml writes won't apply until after hard reset. This removes that constraint but still requires the password to enable the web workflow.
Fixes #3835