Require 64 bytes extra CDC RX buffer #8929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the buffer has less that an endpoint's worth, TinyUSB won't request more from the host. When that happens, ctrl-c will no longer be sent to the device and TinyUSB won't find the wanted character. Fixes micropython#4444
dhalbert
reviewed
Feb 16, 2024
To give it extra room. I started with 128 but changed the limit to 64 after looking at the samd21 settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the buffer has less that an endpoint's worth, TinyUSB won't request more from the host. When that happens, ctrl-c will no longer be sent to the device and TinyUSB won't find the wanted character.
Fixes #4444