Skip to content

Switch to finaliser for PWMOut and audiopwmio #8966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Feb 21, 2024

Fixes #8726 which was caused by a mix of bulk reset and finaliser use.

Work towards #8960.

Fixes micropython#8726 which was caused by a mix of bulk reset and finaliser
use.

Work towards micropython#8960.
@tannewt tannewt added this to the 9.0.0 milestone Feb 21, 2024
@tannewt tannewt requested a review from dhalbert February 21, 2024 19:54
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various build failures in atmel-samd and raspberrypi due to now-missing routines.

@tannewt
Copy link
Member Author

tannewt commented Feb 21, 2024

Builds are fixed @dhalbert

@dhalbert
Copy link
Collaborator

Thanks! I will do some hw testing a little later.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on an RP2040, creating some PWMOuts and then restarting the VM. Things seem fine. I'm impressed the code has gotten smaller!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pulseio PulseIn causes hard crashes
2 participants