main: Explicitly set the stack top based on _estack #903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. setting it based on the ad-hoc stack pointer calculation of
mp_stack_ctrl_init()
meant that the stack used abovemain()
counts against the 1KiB safety factor that themp_stack_set_limit
call tries to establish. It turns out, at least on M4, that over half of the safety factor is used up by stack-above-main()!In the case of the
basics/gen_stack_overflow.py
test, which blows the stack on purpose, it turns out that gc would be called while handling the "maximum recursion depth exceeded" error, and this needed more stack than was left.Closes: #900