Update floppyio to use newer adafruit_floppy, implement pio-based flux capture on rp2040 #9135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
added a commit
to adafruit/Adafruit_CircuitPython_floppy
that referenced
this pull request
Apr 2, 2024
this **incompatible change** is related to adafruit/circuitpython#9135 When MFM decoding, a separate buffer of flux data is required. Due to its size, this buffer should be created early in the program execution flow.
2b10f10 to
b17e5b2
Compare
dhalbert
previously approved these changes
Apr 3, 2024
|
Thanks! I'll merge this once Adafruit_Floppy sees the related PR merged, then I'll take care of the library third. I think that order makes more sense than anything else. |
|
that is, adafruit/Adafruit_Floppy#32 |
tannewt
requested changes
Apr 3, 2024
Co-authored-by: Scott Shawcroft <scott@tannewt.org>
dhalbert
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes MFM disk reading, too.
this is an incompatible change to floppyio, will require an updated adafruit-circuitpython-floppy (pull request coming soon) and there is no plan for cross-version compatibility. (This was previously discussed & OK'd)