Skip to content

Switch to serial_write for the one line clear that is captured by boot_out.txt #9181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 18, 2024
Merged

Switch to serial_write for the one line clear that is captured by boot_out.txt #9181

merged 5 commits into from
Apr 18, 2024

Conversation

bill88t
Copy link

@bill88t bill88t commented Apr 14, 2024

Fixes #9180.

This is the only function that doesn't get captured into boot_out.txt.
I confirmed the line clear still occurs by adding some junk text.

Serial console setup
amogusAdafruit CircuitPython 9.1.0-beta.0-26-gc978768d37-dirty on 2024-04-15; M5Stack Timer Camera X with ESP32
Board ID:m5stack_timer_camera_x
UID:806BF178DD44
amogusboot.py output:
Early boot log:

The rest of the line clears are outside of what boot_out.txt captures and I opted to keep the existing function calls since they seem more correct.

@bill88t bill88t changed the title Switch to serial_write for the one line clear that is stored in boot_out.txt Switch to serial_write for the one line clear that is captured by boot_out.txt Apr 14, 2024
dhalbert
dhalbert requested changes Apr 18, 2024
View reviewed changes
@jepler
Copy link

jepler commented Apr 18, 2024

That confusion may be my fault. I would think renaming serial_write_compressed (to what?) would be helpful for the next person.

@bill88t
Copy link
Author

bill88t commented Apr 18, 2024

I do not think a function rename is warranted.
However I do think some commenting is needed.

@bill88t
Copy link
Author

bill88t commented Apr 18, 2024

The one print below was safe to change to mp_hal_stdout_tx_str.

dhalbert
dhalbert requested changes Apr 18, 2024
View reviewed changes
@bill88t
Copy link
Author

bill88t commented Apr 18, 2024

Something changed with readthedocs.

looking for now-outdated files... none found
pickling environment... WARNING: cannot cache unpickable configuration value: 'autoapi_prepare_jinja_env' (because it contains a function, class, or module object)
done

@dhalbert
Copy link
Collaborator

Something changed with readthedocs.

This is a new warning caused by a new version of sphinx. We have to now ignore the warning. Fixed in #9186 for 9.0.x. Awaits merging into main via #9187.

dhalbert
dhalbert approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit e74a4e5 into adafruit:main Apr 18, 2024
@bill88t bill88t deleted the fix9180 branch April 18, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected Characters in boot_out.txt
3 participants
@bill88t @jepler @dhalbert