Fix exception chaining for non-built-in exceptions #9266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on a This code will fail, since the MQTT server isn't connecting vis SSL, but on a SSL port: import adafruit_connection_manager
import wifi
esp = wifi.radio
pool = adafruit_connection_manager.get_radio_socketpool(esp)
ssl_context = adafruit_connection_manager.get_radio_ssl_context(esp)
import adafruit_minimqtt.adafruit_minimqtt as MQTT
mqtt_client = MQTT.MQTT(
broker="io.adafruit.com",
username="ADAFRUIT_AIO_USERNAME",
password="ADAFRUIT_AIO_KEY",
port=8883,
socket_timeout=1,
recv_timeout=2,
socket_pool=pool,
ssl_context=ssl_context,
is_ssl=False,
)
mqtt_client.connect()Result: |
|
@justmobilize so are you saying it works for you? Not sure :) |
|
@dhalbert , yes I now see both exceptions. This works perfectly |
dhalbert
approved these changes
May 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause was that setting the
__cause__property on an exception didn't set the built in exception object's cause property, so it's necessary to fetch the property from the actual object when needed.