Skip to content

shared-module/sdcardio/SDCard.c: check for deinit more thoroughly #9418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Jul 9, 2024

Some deinit checks were missing. Refactored where the check was called to check everywhere.

Tested on a Metro ESP32-S3. Also tested on a Metro RP2040 but that does not crash as easily. 😄

@RetiredWizard

@dhalbert dhalbert requested review from tannewt and jepler July 9, 2024 14:43
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, didn't test. thank you!

@dhalbert dhalbert merged commit 685101f into adafruit:main Jul 9, 2024
444 checks passed
@dhalbert dhalbert deleted the sdcardio-deinit-check branch July 9, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using storage.VfsFat(sd) object after sd has been deinit causes safemode crash
2 participants