Skip to content

Switch to Feather52s full name to avoid confusion with the nrf52840 later #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2018
Merged

Switch to Feather52s full name to avoid confusion with the nrf52840 later #945

merged 3 commits into from
Jun 18, 2018

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jun 18, 2018

Fixes #940

@tannewt tannewt added the nordic label Jun 18, 2018
@tannewt tannewt added this to the 3.0 milestone Jun 18, 2018
ladyada
ladyada previously approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

arturo182
arturo182 previously approved these changes Jun 18, 2018
View reviewed changes
@tannewt tannewt dismissed stale reviews from arturo182 and ladyada via 724bd7c June 18, 2018 21:07
@tannewt
Copy link
Member Author

tannewt commented Jun 18, 2018

Travis is green. Can someone re-review please? Thanks!

dhalbert
dhalbert approved these changes Jun 18, 2018
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm @dhalbert and I approve this message.

@dhalbert dhalbert merged commit f5fab35 into adafruit:master Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@arturo182 arturo182 arturo182 left review comments

@ladyada ladyada ladyada left review comments

Assignees
No one assigned
Labels
nordic
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tannewt @arturo182 @ladyada @dhalbert