A few heap related tweaks #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tannewt
commented
Jul 3, 2018
- Long live byte strings
- Long live code.py code
- Collect after import
- Limit max QSTR pool size
This prevents bugs where gc_collect is called from C code that did a recent allocation.
Imports generate a lot of garbage so cleaning it up immediately reduces the likelihood longer lived data structures don't end up in the middle of the heap. Fixes micropython#856
|
Travis is testing nrf fix. In the meantime I forgot to post the videos: before: https://www.youtube.com/watch?v=dabIOpBfnks |
dhalbert
previously approved these changes
Jul 3, 2018
arturo182
reviewed
Jul 3, 2018
ports/nrf/Makefile
Outdated
| @@ -213,7 +213,7 @@ FROZEN_MPY_PY_FILES := $(shell find -L $(FROZEN_MPY_DIR) -type f -name '*.py') | |||
| FROZEN_MPY_MPY_FILES := $(addprefix $(BUILD)/,$(FROZEN_MPY_PY_FILES:.py=.mpy)) | |||
|
|
|||
| OBJ += $(PY_O) $(SUPERVISOR_O) $(addprefix $(BUILD)/, $(SRC_C:.c=.o)) | |||
| OBJ += $(BUILD)/pins_gen.o | |||
| OBJ += $(BUILD)/pins_gen.o supervisor/cpu.o | |||
There was a problem hiding this comment.
Adding a SRC_S variable and then using addprefix to change to .o would probably be cleaner :)
There was a problem hiding this comment.
Done. Thanks for the comment
dhalbert
previously requested changes
Jul 3, 2018
ports/atmel-samd/Makefile
Outdated
| @@ -412,13 +412,16 @@ endif | |||
| SRC_SHARED_MODULE_EXPANDED = $(addprefix shared-bindings/, $(SRC_SHARED_MODULE)) \ | |||
| $(addprefix shared-module/, $(SRC_SHARED_MODULE)) | |||
|
|
|||
| SRC_O = supervisor/$(CHIP_FAMILY)_cpu.o | |||
|
|
|||
There was a problem hiding this comment.
Same thing here that you did in the nrf makefile?
There was a problem hiding this comment.
Done! Please take another look.
|
@dhalbert Please take a look! |
dhalbert
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.