Skip to content

Fix version in circuitpython-stubs #9948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2025
Merged

Fix version in circuitpython-stubs #9948

merged 3 commits into from
Jan 11, 2025

Conversation

jepler
Copy link

@jepler jepler commented Jan 10, 2025 •
edited
Loading

the configuration that tried to use setuptools_scm was broken. Instead, provides circuitpython-stubs' setup.py with the version determined by setuptools_scm running in the git source directory.

This gets rid of the following message seen during the doc build in github actions:

WARNING setuptools_scm.pyproject_reading toml section missing 'pyproject.toml does not contain a tool.setuptools_scm section'
Traceback (most recent call last):
  File "/tmp/build-env-dsk5kdxt/lib/python3.12/site-packages/setuptools_scm/_integration/pyproject_reading.py", line 36, in read_pyproject
    section = defn.get("tool", {})[tool_name]
              ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^
KeyError: 'setuptools_scm'

Compared to the version originally in #9947 this adds fetching tags during the doc build.

Remember to also check if this worked on RTD!

jepler added 3 commits January 10, 2025 15:24
@jepler
Fix version in circuitpython-stubs
35ce615 
the configuration that tried to use setuptools_scm was broken.
Instead, provides circuitpython-stubs' setup.py with the version
determined by setuptools_scm running in the git source directory.
@jepler
Ensure git version info is available when building docs in CI
91ed9fa 
(also need to check on rtd!)
@jepler
setuptools_scm now needed during 'make check-stubs'
f914995
@jepler jepler requested a review from dhalbert January 11, 2025 19:01
dhalbert
dhalbert approved these changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring out that mysterious error!

@dhalbert dhalbert merged commit 338c1aa into adafruit:main Jan 11, 2025
587 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @dhalbert