Get package name from pyproject.toml, allow arbitrary files in packages #101
Conversation
This is more dependable, and when we know the package name we can
glob inside it to get all files such as bin or ttf files.
This will allow e.g., 5x8.bin & ov5640_autofocus.bin within
bundles.
the behavior of bundlefly and circup when encountering .bin files
needs to be checked.
Tested by building modified pycamera bundle and the autofocus.bin file
appears in the generated zip files:
```
pycamera-py-ec67bde/lib/adafruit_pycamera/ov5640_autofocus.bin 4077 4096
pycamera-8.x-mpy-ec67bde/lib/adafruit_pycamera/ov5640_autofocus.bin 4077 4096
pycamera-9.x-mpy-ec67bde/lib/adafruit_pycamera/ov5640_autofocus.bin 4077 4096
```
There's at least one library in the bundle that has incorrect metadata
and that leads to an error:
adafruit/Adafruit_CircuitPython_Colorsys#29
6de3690 to
033bf0a
Compare
|
circup appears to use |
033bf0a to
b2116cb
Compare
(it's smaller on disk)
b2116cb to
0c58704
Compare
|
This'll require some metadata problems across multiple libs to be corrected. |
|
The test failure appears to be due to wrong metadata. I think I've filed PRs with every affected library now. |
|
I have settings.toml on the brain because of circuitpython, but it should be pyproject.toml everywhere here. |
|
Trying to think of a creative way to let this land without requiring all those libs to be updated. Could be as simple as a blacklist of things that DON'T get the treatment, or disabling it in the communty bundle for now. (allowing the build process to opt out of using the new thing) |
|
I've implemented a simple blacklist (of values that appear in py_modules today and are wrong) so that this can complete CI without all those related issues being closed. |
|
None of the repos under jposada202020 have been fixed, and they have no github activity in the last year. If it is important to get rid of this list of non-comforming libraries, we may need to fork them (e.g., into the circuitpython org) so they can be group maintained. |
|
@jepler sorry about that I create the tag release as requested. Sorry about the delay |
|
Thanks @jposada202020, that's appreciated! |
This is more dependable, and when we know the package name we can glob inside it to get all files such as bin or ttf files.
This will allow e.g., 5x8.bin & ov5640_autofocus.bin within
bundles.
the behavior of bundlefly and circup when encountering .bin files needs to be checked.
Tested by building modified pycamera bundle and the autofocus.bin file appears in the generated zip files:
There's at least one library in the bundle that has incorrect metadata and that leads to an error:
adafruit/Adafruit_CircuitPython_Colorsys#29