Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By converting dependencies to
_
, the 1.10.2 release scrambled the requirements in the json file, moving all "dependencies" to "external dependencies" with an underscored pypi name instead of the library name (adafruit_circuitpython_hid
instead ofadafruit_hid
).This PR uses
-
not_
to reference modules from dependencies, so it matches the index used inpackage_list
and the pypi_name field. Use the same function in both parts to emphasize their relatedness. The original name before transformation is still used in external_dependencies.Note: this does not keep the same format as pipkin as intended by #90. pipkin can map the format function on the list to make sure every reference uses the same format without having to edit the list manually.
Additionally:
~[;
to filter requirements and strip() spaces. See here examples of valid formats.if line in dependencies
would always be False. (testing the presence ofadafruit-circuitpython-dotstar
before addingadafruit_dotstar
).spidev
to the list of skipped dependencies. (Found in the community bundle).With this PR the generated json matches the one generated by 1.10.1 except newly skipped libraries are skipped (
pyasn1
,pillow
,spidev
), and bad dependencies are fixed (typing-extensions~
).