Skip to content

Add NFC Copy Cat by Electronic Cats #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2020
Merged

Add NFC Copy Cat by Electronic Cats #449

merged 3 commits into from
Apr 9, 2020

Conversation

sabas1080
Copy link
Contributor

Hi

Please add NFC Copy Cat

Depended of adafruit/circuitpython#2758

Thanks

makermelissa
makermelissa requested changes Apr 9, 2020
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding. Data file looks good, but images are a tad large. For instance, your small image is 3286x3286. You can find more details about the correct sizing here: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/preparing-the-images

makermelissa
makermelissa approved these changes Apr 9, 2020
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@makermelissa makermelissa merged commit 6b50182 into adafruit:master Apr 9, 2020
@sabas1080
Copy link
Contributor Author

Thanks! :D @makermelissa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabas1080 @makermelissa