🚨 [security] Update @octokit/plugin-paginate-rest 2.3.0 → 11.4.2 (major) #60

depfu · 2025-02-14T18:05:37Z

Welcome to Depfu 👋

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ @octokit/plugin-paginate-rest (2.3.0 → 11.4.2) · Repo

Security Advisories 🚨

🚨 @octokit/plugin-paginate-rest has a Regular Expression in iterator Leads to ReDoS Vulnerability Due to Catastrophic Backtracking

Summary

For the npm package @octokit/plugin-paginate-rest, when calling octokit.paginate.iterator(), a specially crafted octokit instance—particularly with a malicious link parameter in the headers section of the request—can trigger a ReDoS attack.

Details

The issue occurs at line 39 of iterator.ts in the @octokit/plugin-paginate-rest repository. The relevant code is as follows:
url = ((normalizedResponse.headers.link || "").match(
  /<([^>]+)>;\s*rel="next"/,
) || [])[1];
The regular expression /<([^>]+)>;\s*rel="next"/ may lead to a potential backtracking vulnerability, resulting in a ReDoS (Regular Expression Denial of Service) attack. This could cause high CPU utilization and even service slowdowns or freezes when processing specially crafted Link headers.

PoC

The gist of PoC.js

run npm i @octokit/plugin-paginate-rest

run 'node poc.js'
result:

then the program will stuck forever with high CPU usage
import { Octokit } from "@octokit/core";
import { paginateRest } from "@octokit/plugin-paginate-rest";
const MyOctokit = Octokit.plugin(paginateRest);

const octokit = new MyOctokit({

auth: "your-github-token",

});
// Intercept the request to inject a malicious 'link' header for ReDoS

octokit.hook.wrap("request", async (request, options) => {

const maliciousLinkHeader = "" + "<".repeat(100000) + ">"; // attack string

return {

data: [],

headers: {

link: maliciousLinkHeader, // Inject malicious 'link' header

},

};

});
// Trigger the ReDoS attack by paginating through GitHub issues

(async () => {

try {

for await (const normalizedResponse of octokit.paginate.iterator(

"GET /repos/{owner}/{repo}/issues", { owner: "DayShift", repo: "ReDos", per_page: 100 }

)) {

console.log({ normalizedResponse });

}

} catch (error) {

console.error("Error encountered:", error);

}

})();
Impact

What kind of vulnerability is it?

This is a Regular Expression Denial of Service (ReDoS) vulnerability, which occurs due to excessive backtracking in the regex pattern:
/<([^>]+)>;\s*rel="next"/
When processing a specially crafted Link header, this regex can cause significant performance degradation, leading to high CPU utilization and potential service unresponsiveness.

Who is impacted?

Users of @octokit/plugin-paginate-rest who call octokit.paginate.iterator() and process untrusted or manipulated Link headers.

Applications relying on Octokit's pagination mechanism, particularly those handling large volumes of API requests.

GitHub API consumers who integrate this package into their projects for paginated data retrieval.

🚨 @octokit/plugin-paginate-rest has a Regular Expression in iterator Leads to ReDoS Vulnerability Due to Catastrophic Backtracking

Summary

For the npm package @octokit/plugin-paginate-rest, when calling octokit.paginate.iterator(), a specially crafted octokit instance—particularly with a malicious link parameter in the headers section of the request—can trigger a ReDoS attack.

Details

The issue occurs at line 39 of iterator.ts in the @octokit/plugin-paginate-rest repository. The relevant code is as follows:
url = ((normalizedResponse.headers.link || "").match(
  /<([^>]+)>;\s*rel="next"/,
) || [])[1];
The regular expression /<([^>]+)>;\s*rel="next"/ may lead to a potential backtracking vulnerability, resulting in a ReDoS (Regular Expression Denial of Service) attack. This could cause high CPU utilization and even service slowdowns or freezes when processing specially crafted Link headers.

PoC

The gist of PoC.js

run npm i @octokit/plugin-paginate-rest

run 'node poc.js'
result:

then the program will stuck forever with high CPU usage
import { Octokit } from "@octokit/core";
import { paginateRest } from "@octokit/plugin-paginate-rest";
const MyOctokit = Octokit.plugin(paginateRest);

const octokit = new MyOctokit({

auth: "your-github-token",

});
// Intercept the request to inject a malicious 'link' header for ReDoS

octokit.hook.wrap("request", async (request, options) => {

const maliciousLinkHeader = "" + "<".repeat(100000) + ">"; // attack string

return {

data: [],

headers: {

link: maliciousLinkHeader, // Inject malicious 'link' header

},

};

});
// Trigger the ReDoS attack by paginating through GitHub issues

(async () => {

try {

for await (const normalizedResponse of octokit.paginate.iterator(

"GET /repos/{owner}/{repo}/issues", { owner: "DayShift", repo: "ReDos", per_page: 100 }

)) {

console.log({ normalizedResponse });

}

} catch (error) {

console.error("Error encountered:", error);

}

})();
Impact

What kind of vulnerability is it?

This is a Regular Expression Denial of Service (ReDoS) vulnerability, which occurs due to excessive backtracking in the regex pattern:
/<([^>]+)>;\s*rel="next"/
When processing a specially crafted Link header, this regex can cause significant performance degradation, leading to high CPU utilization and potential service unresponsiveness.

Who is impacted?

Users of @octokit/plugin-paginate-rest who call octokit.paginate.iterator() and process untrusted or manipulated Link headers.

Applications relying on Octokit's pagination mechanism, particularly those handling large volumes of API requests.

GitHub API consumers who integrate this package into their projects for paginated data retrieval.

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by 2 commits:

🆕 @octokit/openapi-types (added, 12.11.0)

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

sourcery-ai · 2025-02-14T18:05:43Z

Reviewer's Guide by Sourcery

This pull request updates the @octokit/plugin-paginate-rest dependency from version 2.3.0 to 11.4.2 to address a security vulnerability. The update includes a new dependency @octokit/openapi-types.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
The `@octokit/plugin-paginate-rest` dependency was updated from version 2.3.0 to 11.4.2. This resolves a ReDoS vulnerability.	Updated `@octokit/plugin-paginate-rest` to address a security vulnerability related to regular expression denial of service (ReDoS). The update includes fixes and improvements from multiple releases between 2.3.0 and 11.4.2. A new dependency `@octokit/openapi-types` was added.	`package.json` `package-lock.json`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

performance-testing-bot · 2025-02-14T18:05:44Z

Unable to locate .performanceTestingBot config file

sourcery-ai

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, depfu[bot]!). We assume it knows what it's doing!

Update @octokit/plugin-paginate-rest to version 11.4.2

cbee73e

depfu bot added the depfu label Feb 14, 2025

pull-request-size bot added the size/XS label Feb 14, 2025

sourcery-ai bot reviewed Feb 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚨 [security] Update @octokit/plugin-paginate-rest 2.3.0 → 11.4.2 (major) #60

🚨 [security] Update @octokit/plugin-paginate-rest 2.3.0 → 11.4.2 (major) #60

depfu bot commented Feb 14, 2025 •

edited

Loading

sourcery-ai bot commented Feb 14, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

performance-testing-bot bot commented Feb 14, 2025

sourcery-ai bot left a comment

🚨 [security] Update @octokit/plugin-paginate-rest 2.3.0 → 11.4.2 (major) #60

Are you sure you want to change the base?

🚨 [security] Update @octokit/plugin-paginate-rest 2.3.0 → 11.4.2 (major) #60

Conversation

depfu bot commented Feb 14, 2025 • edited Loading

What changed?

✳️ @​octokit/plugin-paginate-rest (2.3.0 → 11.4.2) · Repo

🚨 @octokit/plugin-paginate-rest has a Regular Expression in iterator Leads to ReDoS Vulnerability Due to Catastrophic Backtracking

Summary

Details

PoC

Impact

What kind of vulnerability is it?

Who is impacted?

🚨 @octokit/plugin-paginate-rest has a Regular Expression in iterator Leads to ReDoS Vulnerability Due to Catastrophic Backtracking

Summary

Details

PoC

Impact

What kind of vulnerability is it?

Who is impacted?

🆕 @​octokit/openapi-types (added, 12.11.0)

sourcery-ai bot commented Feb 14, 2025 • edited Loading

Reviewer's Guide by Sourcery

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

performance-testing-bot bot commented Feb 14, 2025

sourcery-ai bot left a comment

Choose a reason for hiding this comment

depfu bot commented Feb 14, 2025 •

edited

Loading

✳️ @octokit/plugin-paginate-rest (2.3.0 → 11.4.2) · Repo

🆕 @octokit/openapi-types (added, 12.11.0)

sourcery-ai bot commented Feb 14, 2025 •

edited

Loading