Skip to content

Implemented counting sort #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2016

Conversation

jarettgross
Copy link
Contributor

Implemented counting sort algorithm, placed it under "Sorting"

@64json
Copy link
Member

64json commented Jun 12, 2016

Thanks for contributing.
For the next time, can you run gulp or gulp build before you push it?
Since files in /public directory are automatically built, they should not be changed unless you changed stylesheet or core javascript files.

@64json 64json merged commit 4f0620d into algorithm-visualizer:gh-pages Jun 12, 2016
@jarettgross
Copy link
Contributor Author

Sure thing. I tried doing that the past couple of times, but it looks as though 15+ files are changed after I run gulp even though I didn't touch them. Am I supposed to commit all of those modified files every time I make a change?

@64json
Copy link
Member

64json commented Jun 12, 2016

Never mind, this may not be your fault.
I will figure out how to automatically build those files when merging.

@duaraghav8
Copy link
Member

@parkjs814 https://libraries.io/npm/javascript-gulp-precommit
not sure but might help

@64json
Copy link
Member

64json commented Jun 13, 2016

@duaraghav8 Actually gulp should build after we merge the pull request, not before pushing it.
I don't know what to do hmm..

@TornjV
Copy link
Member

TornjV commented Jun 13, 2016

@parkjs814 We could use travis.

@64json
Copy link
Member

64json commented Jun 13, 2016

@TornjV Isn't travis only for the deployment to server?

@nem035
Copy link
Member

nem035 commented Jun 13, 2016

@TornjV might be on to something: https://gist.github.com/domenic/ec8b0fc8ab45f39403dd

@64json
Copy link
Member

64json commented Jun 13, 2016

@TornjV @nem035, mhm that can be one possible solution.
I guess it is time to move to AWS or Heroku, there are too many limitations as well as this issue.

@jarettgross
Copy link
Contributor Author

@parkjs814, so for future commits, should I run gulp before pushing, or just push files that I explicitly changed?

@64json
Copy link
Member

64json commented Jun 13, 2016

@jarettgross,
I figured out that there will be no difference whether you run gulp or not.
Don't worry about this issue, and just send a pull request.
I will care about it.
Sorry for the inconvenience.

@jarettgross jarettgross deleted the counting-sort branch June 13, 2016 16:39
64json added a commit that referenced this pull request Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants