Skip to content

Made changes to the efficient bridge-finding algorithm #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Made changes to the efficient bridge-finding algorithm #92

wants to merge 11 commits into from

Conversation

jonathanxia
Copy link
Contributor

Ignore the server.py file, that was just so I could run it on localhost.

I made some changes to the efficient bridge-finding algorithm (the non-naive one):

  1. Added a description of the algorithm
  2. Made some changes to the algorithm. Removed the visited[] and parent[] arrays, and used -1 to indicate non-visited.
  3. Also changed the algorithm a bit, so that when a cycle is hit, the DFS can directly change the values of low[]
  4. Also edited the tracing, defining a trace() function and then placing it after each visit (makes more sense that way).

jonathanxia and others added 11 commits May 26, 2016 21:42
@jonathanxia
server.py added
20a9858 
Added server.py so I could run this on localhost
@jonathanxia
Deleted server.js
955be07 
oops
@jonathanxia
Merge branch 'gh-pages' of https://github.com/parkjs814/AlgorithmVisu…
1e3c863 
…alizer into gh-pages
@jonathanxia
Merge branch 'gh-pages' of https://github.com/parkjs814/AlgorithmVisu…
b8f6675 
…alizer into gh-pages
@jonathanxia
Added a description of efficient bridges
2ec43f2 
Description of the efficient bridges algorithm
@jonathanxia
Merge branch 'gh-pages' of https://github.com/parkjs814/AlgorithmVisu…
99abd58 
…alizer into gh-pages

# Conflicts:
#	index.html
@64json
Merge branch 'gh-pages' of https://github.com/parkjs814/AlgorithmVisu…
ef36693 
…alizer into gh-pages
@jonathanxia
Condensed efficient bridge-finding
baf7508 
-Added a description of the efficient algorithm
-Eliminated the visited and parent array, more space efficient to use -1
to indicate something not visited. Only parent of current node is
needed.
@jonathanxia
Merge remote-tracking branch 'refs/remotes/parkjs814/gh-pages' into g…
873aeba 
…h-pages

# Conflicts:
#	index.html
@jonathanxia
Merge remote-tracking branch 'refs/remotes/origin/gh-pages' into park…
39e1511 
…js814/gh-pages
@jonathanxia
Fixed minor error in trace()
e25f404 
Forgot the semicolon oops
@TornjV
Copy link
Member

TornjV commented May 27, 2016

There are extra files and conflicts weren't dealt with. Please send another pr after just making fixes around the bridge finding algorithm.

@TornjV TornjV closed this May 27, 2016
@jonathanxia
Copy link
Contributor Author

I only changed things around the bridge finding algorithm. I did periodically update from the parkjs814 gh-pages branch, and when I send in the pr it has hundreds of file having no changes except for the "File mode changed". How should I get rid of that?

@nem035
Copy link
Member

nem035 commented May 28, 2016

Hi @fclvbfm934, a few suggestions:

  1. You don't need to create a server.py. Since you have python installed, you can just run python -m SimpleHTTPServer and that's it.
  2. As far as all the file modes changing, take a look at this Stackoverflow issue

@jonathanxia
Copy link
Contributor Author

Hi,
I removed server.py already. Thanks!

Regarding the file modes, I tried typing that into the shell and the pull request still has the file mode changes. I'm kind of new to using GitHub so I'm not quite sure what to do. (sorry if this is a dumb question). I'm using the GitHub Desktop application, so what should I do to get rid of this file mode change?

@jonathanxia jonathanxia mentioned this pull request May 31, 2016
Merged
@snyk-bot snyk-bot mentioned this pull request May 31, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jun 21, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 16, 2022
Open
@snyk-community snyk-community mentioned this pull request Oct 2, 2023
Open
@snyk-community snyk-community mentioned this pull request Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathanxia @TornjV @nem035 @64json