Skip to content

fix BuildTestName and add attachment in report for gherkin #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2021
Merged

fix BuildTestName and add attachment in report for gherkin #71

merged 1 commit into from
Jun 3, 2021

Conversation

DolgushinG
Copy link
Contributor

Codeception 3.0.2 + Behat/gherkin 4.4.0 + Allure-codeception 1.4.0

  1. I fixed generate allure-report with testName scenario instead testName feature
    Details to buildTestName here:
    change buildTestName for behat/gherkin  #70
    2.I added able in Allure generate report with attachments for gherkin

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@baev baev added the type:bug label Jun 1, 2021
@DolgushinG
Copy link
Contributor Author

@eroshenkoam could you see my PR ? and after if there is all right ok review and merge please

remorhaz
remorhaz approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@remorhaz remorhaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version check could be performed once, but in general this PR seems to be OK.

@baev baev merged commit f9bce40 into allure-framework:master Jun 3, 2021
@baev baev mentioned this pull request Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev baev approved these changes

+1 more reviewer

@remorhaz remorhaz remorhaz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DolgushinG @CLAassistant @baev @remorhaz