Skip to content

Fix enum34 dependency for python versions > 3.4 #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2017

Conversation

gelioz
Copy link
Contributor

@gelioz gelioz commented Nov 17, 2017

Added python_version environment marker for install_requires to fix situation when allure-python-commons dependency enum34 was added to universal wheel file without proper handling of python version.

Context

Currently, enum34 dependency for allure-python-commons is added depending on python version of build system instead of python version of setup destination.

This issue can be reproduced by installation of allure-pytest==2.2.3b1 from PyPi whl file on python 3.6. This will install enum34 library for 3.6 system and cause internal python exceptions, like:

  File "/opt/jenkins/shiningpanda/jobs/af2a4440/virtualenvs/d41d8cd9/bin/coverage", line 4, in <module>
    import re
  File "/opt/jenkins/shiningpanda/jobs/af2a4440/virtualenvs/d41d8cd9/lib/python3.6/re.py", line 142, in <module>
    class RegexFlag(enum.IntFlag):
AttributeError: module 'enum' has no attribute 'IntFlag'```

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2017

CLA assistant check
All committers have signed the CLA.

@sseliverstov sseliverstov merged commit 6ce4dbd into allure-framework:master Nov 17, 2017
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants