Update listener.py #183
Update listener.py #183
Conversation
added exception for getting finalizer allure-framework#181.
|
|
allure-pytest/src/listener.py
Outdated
| for index, finalizer in enumerate(fixturedef._finalizer or ()): | ||
| name = '{fixture}::{finalizer}'.format(fixture=fixturedef.argname, finalizer=finalizer.__name__) | ||
| fixturedef._finalizer[index] = allure_commons.fixture(finalizer, parent_uuid=container_uuid, name=name) | ||
| try: |
There was a problem hiding this comment.
may be without code duplication and error handling? like this:
...
finalizers = fixturedef._finalizer if hasattr(fixturedef, 'finalizer') else fixturedef._finalizers
for index, finalizer in enumerate(finalizers or ()):
...
cleaned code duplication and error handling.
|
I would correct, but I can't understand what not so for py33. |
|
Pytest no longer supports Python 2.6 and 3.3. Those Python versions are EOL for some time now and incur maintenance and compatibility costs on the pytest core team, and following up with the rest of the community we decided that they will no longer be supported starting on this version. Users which still require those versions should pin pytest to <3.3. (#2812) |
|
needs some changes in tox.ini ( |
remove py33
remove py33
remove py33
remove py33
removed a blank line
added exception for getting finalizer. fixes #181.
Context
Checklist