Skip to content

Fix missing fixtures in report when using lazy_fixture #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 25, 2021
Merged

Fix missing fixtures in report when using lazy_fixture #548

merged 6 commits into from
Jan 25, 2021

Conversation

dgusakov
Copy link
Contributor

@dgusakov dgusakov commented Jan 20, 2021

There is a well known issue with missing fixtures in allure-report when using lazy_fixture plugin

Since during runtime fixtures can be added to item._request.fixturenames it looks reasonable to take fixturenames list from here and not from item.fixturenames where fixturenames are filled only at the built-in pytest collect stage.

Checklist

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2021

CLA assistant check
All committers have signed the CLA.

@sseliverstov sseliverstov merged commit 6e7fe49 into allure-framework:master Jan 25, 2021
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants