Skip to content

chore(commons): tiny fixes of step type checking #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

chore(commons): tiny fixes of step type checking #846

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4781cde
refactor(commons): remove redundant types from step impl
delatrie Mar 27, 2025
6eb7010
chore(commons): ignore step wrapper typing error
delatrie Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions allure-python-commons/src/_allure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from functools import wraps
from typing import Any, Callable, TypeVar, Union, overload
from typing import Any, Callable, TypeVar, overload

from allure_commons._core import plugin_manager
from allure_commons.types import LabelType, LinkType, ParameterMode
Expand Down Expand Up @@ -162,14 +162,16 @@ def manual():


@overload
def step(title: str) -> "StepContext": ...
def step(title: str) -> "StepContext":
...


@overload
def step(title: _TFunc) -> _TFunc: ...
def step(title: _TFunc) -> _TFunc:
...


def step(title: Union[str, _TFunc]) -> Union["StepContext", _TFunc]:
def step(title):
if callable(title):
return StepContext(title.__name__, {})(title)
else:
Expand Down Expand Up @@ -199,7 +201,7 @@ def impl(*a, **kw):
with StepContext(self.title.format(*args, **params), params):
return func(*a, **kw)

return impl
return impl # type: ignore


class Attach:
Expand Down