Improve PSScriptAnalyzer #171

bravo-kernel · 2023-09-10T10:53:34Z

Replace github action with powershell run command (so we can report full file paths)
Scan source files instead of compiled module
Also scan tests files from now on
Fix errors

vercel · 2023-09-10T10:53:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docusaurus-powershell	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 10, 2023 2:43pm

github-actions · 2023-09-10T13:23:38Z

PSScriptAnalyzer results:

Errors: [0], Warnings: [27], Information: [0]


RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : GetCustomEditUrl.Tests.ps1
Line       : 10
Message    : The variable 'DummyMarkdownFile' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : GetCustomEditUrl.Tests.ps1
Line       : 11
Message    : The variable 'DummyModuleFile' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 16
Message    : The variable 'generatedMdx' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 17
Message    : The variable 'expectedMdx' is assigned but never used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : HtmlEncodeLessThanBrackets.psm1
Line       : 42
Message    : The parameter 'Dummy' has been declared but not used. 

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 16
Message    : The variable 'generatedMdx' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 17
Message    : The variable 'expectedMdx' is assigned but never used.

RuleName   : PSReviewUnusedParameter
Severity   : Warning
ScriptName : UnescapeInlineCode.psm1
Line       : 51
Message    : The parameter 'Dummy' has been declared but not used. 

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 16
Message    : The variable 'generatedMdx' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 17
Message    : The variable 'expectedMdx' is assigned but never used.

RuleName   : PSUseSingularNouns
Severity   : Warning
ScriptName : SeparateMarkdownHeadings.psm1
Line       : 1
Message    : The cmdlet 'Test-SeparateMarkdownHeadings' uses a plural noun. A 
             singular noun should be used instead.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 16
Message    : The variable 'generatedMdxWithPlaceholders' is assigned but never 
             used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 17
Message    : The variable 'expectedMdxWithPlaceholders' is assigned but never 
             used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 24
Message    : The variable 'generatedMdxWithoutPlaceholders' is assigned but 
             never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 25
Message    : The variable 'expectedMdxWithoutPlaceholders' is assigned but 
             never used.

RuleName   : PSUseSingularNouns
Severity   : Warning
ScriptName : PlaceholderExamples.psm1
Line       : 1
Message    : The cmdlet 'Test-PlaceholderExamples' uses a plural noun. A 
             singular noun should be used instead.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 16
Message    : The variable 'generatedMdx' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 17
Message    : The variable 'expectedMdx' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 6
Message    : The variable 'isPS7' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 18
Message    : The variable 'generatedMdx' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 19
Message    : The variable 'expectedMdx' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 16
Message    : The variable 'generatedMdx' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 17
Message    : The variable 'expectedMdx' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 16
Message    : The variable 'generatedMdx' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 17
Message    : The variable 'expectedMdx' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 16
Message    : The variable 'generatedMdx' is assigned but never used.

RuleName   : PSUseDeclaredVarsMoreThanAssignments
Severity   : Warning
ScriptName : Integration.Tests.ps1
Line       : 17
Message    : The variable 'expectedMdx' is assigned but never used.

bravo-kernel added 4 commits September 10, 2023 12:48

Switch to microsoft action + scan source files (not the compiled module)

1a8ef45

Run on windows, do not require build

024d64d

Leaner

69a1d97

Fix

3f4514e

Fix path to settings

b7678d2

vercel bot deployed to Preview September 10, 2023 10:55 View deployment

Require build

3eeea8e

vercel bot deployed to Preview September 10, 2023 10:57 View deployment

Exit on fail

a870acd

vercel bot deployed to Preview September 10, 2023 11:04 View deployment

Output sarif file

decb118

vercel bot deployed to Preview September 10, 2023 11:16 View deployment

List failing tests

87efe18

vercel bot deployed to Preview September 10, 2023 11:26 View deployment

Trigger cat

480ad13

vercel bot deployed to Preview September 10, 2023 11:31 View deployment

try cat again

5aab517

vercel bot deployed to Preview September 10, 2023 11:35 View deployment

Catch the analysis failure

5c8a3cf

vercel bot deployed to Preview September 10, 2023 11:40 View deployment

again

3c15c60

vercel bot deployed to Preview September 10, 2023 11:45 View deployment

And again

6bbf75b

vercel bot deployed to Preview September 10, 2023 11:52 View deployment

Make them readable

ec76d52

vercel bot deployed to Preview September 10, 2023 12:09 View deployment

bravo-kernel added 2 commits September 10, 2023 14:11

Casing

ea9ea15

Fix PSUseSingularNouns

5ecd6cc

vercel bot deployed to Preview September 10, 2023 12:28 View deployment

Fix first PSUserDeclaredVarsMoreThanAssignments

6e27c5e

vercel bot deployed to Preview September 10, 2023 12:47 View deployment

Re-add devblackops action

72ef0af

vercel bot deployed to Preview September 10, 2023 13:21 View deployment

Back now

6ebf244

vercel bot deployed to Preview September 10, 2023 13:28 View deployment

Go manual

96b44ef

vercel bot deployed to Preview September 10, 2023 13:51 View deployment

Fix run command

87bea3d

vercel bot deployed to Preview September 10, 2023 13:54 View deployment

Add fail count

118d891

vercel bot deployed to Preview September 10, 2023 14:01 View deployment

Fix PSUseDeclaredVarsMoreThanAssignments errors

e7f1484

vercel bot deployed to Preview September 10, 2023 14:10 View deployment

bravo-kernel added 3 commits September 10, 2023 16:14

Fix remaining PSUseDeclaredVarsMoreThanAssignments

474e759

Fix all but last one

af5f205

Remove orphaned action yml

e79752e

vercel bot deployed to Preview September 10, 2023 14:24 View deployment

Fix final one, test exit code

8cab87f

vercel bot deployed to Preview September 10, 2023 14:31 View deployment

Finalize yaml

1945302

vercel bot deployed to Preview September 10, 2023 14:43 View deployment

bravo-kernel merged commit b6225c1 into main Sep 10, 2023

bravo-kernel deleted the psscript-analyzer branch September 10, 2023 14:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve PSScriptAnalyzer #171

Improve PSScriptAnalyzer #171

Uh oh!

bravo-kernel commented Sep 10, 2023 •

edited

Loading

Uh oh!

vercel bot commented Sep 10, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Sep 10, 2023

Uh oh!

Uh oh!

Improve PSScriptAnalyzer #171

Improve PSScriptAnalyzer #171

Uh oh!

Conversation

bravo-kernel commented Sep 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Sep 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 10, 2023

Uh oh!

Uh oh!

bravo-kernel commented Sep 10, 2023 •

edited

Loading

vercel bot commented Sep 10, 2023 •

edited

Loading