Soft shutdown review comments 2 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amos402
reviewed
Sep 10, 2020
src/runtime/classmanager.cs
Outdated
| @@ -251,7 +251,6 @@ private static void InitClassBase(Type type, ClassBase impl) | |||
| // TODO: deprecate __overloads__ soon... | |||
| Runtime.PyDict_SetItemString(dict, "__overloads__", ctors.pyHandle); | |||
| Runtime.PyDict_SetItemString(dict, "Overloads", ctors.pyHandle); | |||
| ctors.DecrRefCount(); | |||
|
Would it be better if you just switch to old commit rather than add more revert commits? |
When serializing wrapper objects on domain shutdown Addresses comment: pythonnet#958 (comment)
Fixes an issue where there is no current thread state on shutdown. Also fixes a comment in Runtime.Initialize
... of WaitForFullGCComplete on runtime shutdown Addresses comment: pythonnet#958 (comment)
e0f2bed to
80a7644
Compare
Codecov Report
@@ Coverage Diff @@
## soft-shutdown #3 +/- ##
==============================================
Coverage 86.25% 86.25%
==============================================
Files 1 1
Lines 291 291
==============================================
Hits 251 251
Misses 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
...
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG