Skip to content

static field in #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
msdx opened this issue May 14, 2013 · 4 comments
Closed

static field in #229

msdx opened this issue May 14, 2013 · 4 comments
Assignees
@smarek
Labels
moderate
Milestone
1.4.4

Comments

@msdx
Copy link

msdx commented May 14, 2013

I have a question that why define the "mAllowedContentTypes" with static modifier at BinaryHttpResponseHandler.java ？
@smarek
Copy link
Member

smarek commented Oct 14, 2013

Well, I don't see the reason, and to me it looks like it's wrong. Will be fixed and commited in few moments.

@ghost ghost assigned smarek Oct 14, 2013
smarek added a commit that referenced this issue Oct 14, 2013
@smarek
Fixed wrong static field, Closing #229
f1ab377
@smarek smarek closed this as completed Oct 14, 2013
iNdieboyjeff pushed a commit to iNdieboyjeff/android-async-http that referenced this issue Oct 15, 2013
Merge branch 'master' of https://github.com/loopj/android-async-http
634b29e 
# By mareksebera (7) and Ankush Sachdeva (1)
# Via Ankush Sachdeva (1) and Marek Sebera (1)
* 'master' of https://github.com/loopj/android-async-http:
  Added Proxy Authentication ; fixes android-async-http#328
  Fixed wrong static field, Closing android-async-http#229
  Manual merge, Closing android-async-http#269, android-async-http#118, Closing android-async-http#10, Closing android-async-http#127, android-async-http#154
  Closes android-async-http#137
  Removing duplicate call
  Closing android-async-http#179
  Updated Gradle Android tools version
  Cleaning up error message output
@msdx
Copy link
Author

msdx commented Oct 16, 2013

@smarek Thanks very much for your answer. I also think it may be error, so I raise the issue.

@msdx
Copy link
Author

msdx commented Oct 16, 2013

@iNdieboyjeff Could you tell me how to merge from the repo? I am unfamiliar with the git and github..

@smarek
Copy link
Member

smarek commented Oct 16, 2013

@msdx probably start here: https://help.github.com/articles/syncing-a-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smarek smarek

Labels
moderate
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
2 participants
@smarek @msdx