You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the app doesn't have internet permissions, the post() method never calls any of the callbacks (not even onFinished()) and does not log any error messages.
This issue occurs in the AsyncHttpRequest run() method:
@tr4npt and what is the usecase? Library cannot be used without INTERNET permission, it's basic requirements to use it, so why should library report that? I don't see a point in that.
The point is that any OTHER exception is silently ignored and not reported. This is a simple change to make the library more robust.
Case 1:
IOException occurs -> client program is notified about the error
Case 2:
Any other exception occurs -> client program is not notified
I don't know what other exceptions are possible, but I sure would like to know when they occur. At the very least, the callback interface should be notified that the request is done. In case #2, this does not occur.
I just tried this, removing INTERNET permission from app that uses the library (both JAR and AAR), will receive IOException: Unhandled exception: Permission denied (missing INTERNET permission?)
Have you tried this using latest HEAD or with 1.4.6 ? If it exists as bug in 1.4.6 it is already fixed.
If the app doesn't have internet permissions, the post() method never calls any of the callbacks (not even onFinished()) and does not log any error messages.
This issue occurs in the AsyncHttpRequest run() method:
IOException should be changed to Exception to catch and report this error.
The text was updated successfully, but these errors were encountered: