Skip to content

Make AsyncHttpResponseHandler.ctor more clear #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2015
Merged

Make AsyncHttpResponseHandler.ctor more clear #1021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions library/src/main/java/com/loopj/android/http/AsyncHttpResponseHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,8 @@ public AsyncHttpResponseHandler() {
* @param looper The looper to work with
*/
public AsyncHttpResponseHandler(Looper looper) {
this.looper = looper == null ? Looper.myLooper() : looper;

// Use asynchronous mode by default.
setUseSynchronousMode(false);

// Do not use the pool's thread to fire callbacks by default.
setUsePoolThread(false);
this(looper == null ? Looper.myLooper() : looper, false);
}

/**
Expand All @@ -133,17 +128,24 @@ public AsyncHttpResponseHandler(Looper looper) {
* @param usePoolThread Whether to use the pool's thread to fire callbacks
*/
public AsyncHttpResponseHandler(boolean usePoolThread) {
// Whether to use the pool's thread to fire callbacks.
setUsePoolThread(usePoolThread);

// When using the pool's thread, there's no sense in having a looper.
if (!getUsePoolThread()) {
// Use the current thread's looper.
this.looper = Looper.myLooper();
this(usePoolThread ? null : Looper.myLooper(), usePoolThread);
}

// Use asynchronous mode by default.
setUseSynchronousMode(false);
private AsyncHttpResponseHandler(Looper looper, boolean usePoolThread) {
if (!usePoolThread) {
Utils.asserts(looper != null, "use looper thread, must call Looper.prepare() first!");
this.looper = looper;
// Create a handler on current thread to submit tasks
this.handler = new ResponderHandler(this, looper);
} else {
Utils.asserts(looper == null, "use pool thread, looper should be null!");
// If pool thread is to be used, there's no point in keeping a reference
// to the looper and handler.
this.looper = null;
this.handler = null;
}

this.usePoolThread = usePoolThread;
}

@Override
Expand Down