Skip to content

Make methods that can't be overridden final, inline unneeded ones #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

scottanderson
Copy link

This should serve to further reduce the amount of overhead associated with this library.

@scottanderson
Copy link
Author

This makes the parts of the API that get extended more clear in regards to what behavior is required (abstract), and what behavior can not be overridden (final). In any application that does not override handle*, this is a trivial change.

@loopj
Copy link
Collaborator

loopj commented Mar 27, 2012

I'd prefer to keep these methods overridable, since it allows for more flexibility in applications.

@loopj loopj closed this Mar 27, 2012
@scottanderson
Copy link
Author

Can you provide a little more detail on which methods, specifically, you intend to preserve, and what the reasoning is? The handler behavior isn't something I see a reason to override - is this the concern? The rest of the commit should be innocuous, and if needed I'd like to pick out the offensive parts so the rest can be merged.

@korkag korkag mentioned this pull request Sep 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants