Skip to content

add new catch statement for ConnectTimeoutException #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

add new catch statement for ConnectTimeoutException #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82e009e
catch ConnectTimeoutException and send back an error message in makeR…
Mar 21, 2013
7d502a8
catch RuntimeException in AsyncHttpClient.get when create HttpGet object
Apr 12, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/com/loopj/android/http/AsyncHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,14 @@ public void get(Context context, String url, AsyncHttpResponseHandler responseHa
* @param responseHandler the response handler instance that should handle the response.
*/
public void get(Context context, String url, RequestParams params, AsyncHttpResponseHandler responseHandler) {
sendRequest(httpClient, httpContext, new HttpGet(getUrlWithQueryString(url, params)), null, responseHandler, context);
HttpGet httpGet;
try {
httpGet = new HttpGet(getUrlWithQueryString(url, params));
} catch (RuntimeException e) {
responseHandler.sendFailureMessage(e, e.getMessage());
return;
}
sendRequest(httpClient, httpContext, httpGet, null, responseHandler, context);
}

/**
Expand Down
6 changes: 6 additions & 0 deletions src/com/loopj/android/http/AsyncHttpRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.apache.http.HttpResponse;
import org.apache.http.client.HttpRequestRetryHandler;
import org.apache.http.client.methods.HttpUriRequest;
import org.apache.http.conn.ConnectTimeoutException;
import org.apache.http.impl.client.AbstractHttpClient;
import org.apache.http.protocol.HttpContext;

Expand Down Expand Up @@ -116,6 +117,11 @@ private void makeRequestWithRetries() throws ConnectException {
responseHandler.sendFailureMessage(e, "socket time out");
}
return;
} catch (ConnectTimeoutException e) {
if (responseHandler != null) {
responseHandler.sendFailureMessage(e, "connection time out");
}
return;
} catch (IOException e) {
cause = e;
retry = retryHandler.retryRequest(cause, ++executionCount, context);
Expand Down