Q: why are you using a BinaryResponseHandler, if you receive a String?
I thought that was AsyncHttpResponseHandler's purpose?

cheers

also: mb this is useful here: http://docs.oracle.com/javase/7/docs/api/java/lang/String.html#getBytes%28%29 ?

I'm using it for downloading images. I'm not sure why it is sometimes taken as a String!
Any idea?

ah i c, that's odd indeed. Did you look at what happens in AsyncHttpRequest.makeRequest() ?

This is where I am having a big problem.
I never got this error while testing but have got a lot of crash reports in Google Analytics.
I'm still unable to replicate this situation.

I used this patch and have been monitoring the crash reports. This patch worked!
I don't have any errors in the app.

Referring relevant issues

• BinaryHttpResponseHandler.java: handleMessage cast eror on FAILURE_MESSAGE management #198
• ClassCastException occurs with BinaryHttpResponseHandler when failed to download data. #128
• Fix Bug (java.lang.ClassCastException: String cannot be cast to byte[]) #213

I also encountered the similar problem.
In my case, this problem occurs when socket time out exception occurs. I think that's because I cannot get the binary image at that time.

@kakueki61 yes. if it was a failure, it used to give an exception.

@kakueki61 that's right.
I think master can not test this problem cause of it needs bad internet speed like occurs socket timeout exception. This problem must be resolved as soon as possible..

Hi @rishabhmhjn I want to merge this pull request.
Can you merge in master?

I think I did it! Are you facing errors while merging?

It doesn't look like youve done it. Can you try the following:

• git remote add upstream git@github.com:loopj/android-async-http.git
• git fetch upstream
• git merge upstream/master
• git push origin master

I realized that there is a conflict in BinaryHttpResponseHandler.java

My changes | Your changes

<<<<<<< HEAD
                String res1 = response[1] == null ? "" : response[1].toString();
                handleFailureMessage((Throwable) response[0], res1);
=======
                handleFailureMessage((Throwable)response[0], (byte[]) response[1]);
>>>>>>> loopj/master

I have put my code in production and all the errors have gone.
So should I override my changes onto the above?

Actually @rishabhmhjn it looks like this bug has already been fixed with this commit: 7d10a63

Alright, great.
Thanks.

Hi

I think rishabhmhjn's proposal should still be taken into master build. When socket timeout occurs it still gives classcastexception. But with proposed fix which with toString cast seems to work ok.

@loopj I'm still running into the classcastexception with the latest codebase. I'm using it to download images and when the phone has no connection (say airplane mode), it crashes everytime with a classcastexception.

I get this exception often on some slow public wifi's.
So is there some fix already available ?

@k0rtess this issue should be fixed, if it appeared again, please create new issue and post full stacktrace. Thanks