Fix crash in RetryHandler #295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is is possible for context.getAttribute(...) to return null, so we have to check currentReq before we call getMethod() on it. Without this fix the HttpClient seems to hang forever and onFinish() is never called in the AsyncHttpHandlers.
iNdieboyjeff
pushed a commit
to iNdieboyjeff/android-async-http
that referenced
this pull request
Oct 14, 2013
# By mareksebera (51) and Marek Sebera (2) # Via mareksebera * 'master' of https://github.com/loopj/android-async-http: (53 commits) Handy method to specify charset in anonymous inner instances Sample Application initial state Removed unnecessary dependency, android-async-http#168 Javadoc formatting Fixed 2d34e1c leftover, Closes android-async-http#86 Fixing android-async-http#79, Allowing non-standard HTTP and HTTPS ports Added warning about SSL bypass fix Related to android-async-http#67, avoiding NPE in JsonHttpResponseHandler Fixes android-async-http#61, allow removing of Basic Auth credentials Compatibility changes fix Fixes android-async-http#14 Fixes android-async-http#143 android-async-http#88 uncatched exception Closes android-async-http#266 Closes android-async-http#283 Fixes android-async-http#286 Fixes android-async-http#294 Fixes android-async-http#287 Fixes android-async-http#295 Added Maven description to README file [skip ci] ... Conflicts: .classpath build.gradle project.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for context.getAttribute(...) to return null,
so we have to check currentReq before we call getMethod() on it.
Without this fix the HttpClient seems to hang forever and
onFinish() is never called in the AsyncHttpHandlers.