fix bug: upload more than 2 files in a single post request will be failed #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@realxu great, thank you for noticing this, I haven't got time to look at it yet. But if the bug behaves as you describe, won't that cause problems in 1-2 files usage? I'd expect some conditions on which add the CR_LF length to stream length. |
smarek
added a commit
that referenced
this pull request
Dec 28, 2013
Wrong length calculated when uploading files, Closing #332
|
@smarek For example, the correct end of the request may be “--WTLNkQ9EJE-HyCAyHCPmREm5hfbv--\r\n”. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the function getTotalLength, the length of a single file lost 2 bytes because of the CR_LF.
When uploading 1 file in a single post request, lost 2 bytes, the CR_LF will not be sent.
When uploading 2 file in a single post request, lost 4 bytes, the substring in file split "--" will not be sent.
When uploading more than 2 file in a single post request, lost more than 4 bytes, the last file split will not be complete any more. The server will show an error.