Skip to content

Update the sendResponseMessage with a protected modifier and fix a spelling error. #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Update the sendResponseMessage with a protected modifier and fix a spelling error. #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d821fb
Fix a spelling error in the Javadoc for the setTimeout method.
Aug 16, 2012
f9a2f09
Update the 'sendResponseMessage' with the 'protected' modifier so sub…
Aug 21, 2012
d983537
Add the protected modifier to the binary response handler's sendRespo…
Aug 22, 2012
1414edf
Convert tabs to spaces and fix some formatting in the JSON response h…
Aug 22, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/com/loopj/android/http/AsyncHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ public void setUserAgent(String userAgent) {
}

/**
* Sets the connection time oout. By default, 10 seconds
* Set the connection timeout. By default, 10 seconds.
* @param timeout the connect/socket timeout in milliseconds
*/
public void setTimeout(int timeout){
Expand Down
4 changes: 2 additions & 2 deletions src/com/loopj/android/http/AsyncHttpResponseHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ protected Message obtainMessage(int responseMessage, Object response) {


// Interface to AsyncHttpRequest
void sendResponseMessage(HttpResponse response) {
protected void sendResponseMessage(HttpResponse response) {
StatusLine status = response.getStatusLine();
String responseBody = null;
try {
Expand All @@ -227,4 +227,4 @@ void sendResponseMessage(HttpResponse response) {
sendSuccessMessage(responseBody);
}
}
}
}
2 changes: 1 addition & 1 deletion src/com/loopj/android/http/BinaryHttpResponseHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ protected void handleMessage(Message msg) {
}

// Interface to AsyncHttpRequest
void sendResponseMessage(HttpResponse response) {
protected void sendResponseMessage(HttpResponse response) {
StatusLine status = response.getStatusLine();
Header[] contentTypeHeaders = response.getHeaders("Content-Type");
byte[] responseBody = null;
Expand Down
14 changes: 8 additions & 6 deletions src/com/loopj/android/http/JsonHttpResponseHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,14 @@ protected void handleSuccessJsonMessage(Object jsonResponse) {

protected Object parseResponse(String responseBody) throws JSONException {
Object result = null;
//trim the string to prevent start with blank, and test if the string is valid JSON, because the parser don't do this :(. If Json is not valid this will return null
responseBody = responseBody.trim();
if(responseBody.startsWith("{") || responseBody.startsWith("[")) {
result = new JSONTokener(responseBody).nextValue();
}
return result;
// trim the string to prevent start with blank, and test if the string
// is valid JSON, because the parser don't do this :(. If Json is not
// valid this will return null
responseBody = responseBody.trim();
if (responseBody.startsWith("{") || responseBody.startsWith("[")) {
result = new JSONTokener(responseBody).nextValue();
}
return result;
}

@Override
Expand Down